Text annotation is moved from process to collaboration

mskurz commented 9 years ago

Title: Text annotation is moved from process to collaboration Tool: Enterprise Architect 12.0.1207 Tags: B.1.0, roundtrip, Tool: Enterprise Architect

Enterprise Architect BPMN

    <bpmn:collaboration id="EAID_A0CC40B8_47A2_4273_B3F8_AE9CC4842E9D" isClosed="false">
        [...]
        <bpmn:textAnnotation id="EAID_8D99B7D9_FD83_417c_850C_F9C313823F32" textFormat="text/plain">
            <bpmn:text>Text Annotation</bpmn:text>
        </bpmn:textAnnotation>
        <bpmn:group id="EAID_F2E054D5_61C2_4b72_A84E_36A07F58CA22" categoryValueRef="EAID_CV000000_8974_4806_890D_2EFEB3173345"/>
    </bpmn:collaboration>
    [...]
    <bpmn:process id="EAID_5F0E77E6_C603_445b_A076_3EBF285D9F9A" isClosed="false" processType="None" isExecutable="false">
        [...]
        <bpmn:callActivity id="EAID_5AC3CA0B_A9B1_41b5_ABB2_2F397FE2520C" name="Call Activity Collapsed" startQuantity="1" completionQuantity="1" isForCompensation="false" calledElement="EAID_4F291C7F_2348_4c02_AE8F_3D6CF36BC971">
            <bpmn:incoming>EAID_523040CB_4A13_4f86_B228_3073A00632A3</bpmn:incoming>
            <bpmn:outgoing>EAID_00A59044_6061_4fad_975D_B3B79F307064</bpmn:outgoing>
        </bpmn:callActivity>
        [...]
        <bpmn:association id="EAID_EF002E25_FCDE_4817_9FD7_F9B8C54E2E52" sourceRef="EAID_5AC3CA0B_A9B1_41b5_ABB2_2F397FE2520C" targetRef="EAID_8D99B7D9_FD83_417c_850C_F9C313823F32" associationDirection="None"/>
    </bpmn:process>

Reference BPMN

    <semantic:process isExecutable="false" id="WFP-6-2">
        [...]
        <semantic:callActivity calledElement="WFP-0-" name="Call Activity Collapsed" id="_1237e756-d53c-4591-a731-dafffbf0b3f9">
            <semantic:incoming>_9d489bd9-9435-4692-bc98-4cdda4a61569</semantic:incoming>
            <semantic:outgoing>_10a16fd5-0d56-4fdb-8529-0a0610a573be</semantic:outgoing>
        </semantic:callActivity>
        [...]
        <semantic:textAnnotation id="_4815ea6a-ede2-489b-8b37-2cdb2835b02c">
            <semantic:text>Text Annotation</semantic:text>
        </semantic:textAnnotation>
        <semantic:association associationDirection="None" sourceRef="_1237e756-d53c-4591-a731-dafffbf0b3f9" targetRef="_4815ea6a-ede2-489b-8b37-2cdb2835b02c" id="_5362a7ef-ce7e-4a91-9c38-66c07b1b5f49"/>
    </semantic:process>

Analysis The text annotation is moved from the process element to the collaboration element. However, as text annotations have no semantical impact and the visual representation is unaffected, there is limited practical impact.

dgagne commented 9 years ago

Webmeeting 18 Sept 2015 o We will run XPATH tests on more tools to see if this a specific (EA) tool issue or a generalized problem

mskurz commented 9 years ago

The results of running the XPATH tests on the other tools show that most tools are placing the textAnnotation element in the correct process.

There are only a few exceptions:

Enterprise Architect:Puts the textAnnotation element in the collaboration element instead of the process element (cf. above).
ibo Prometheus: Puts the textAnnotation element in the process element, but uses the wrong name for the callActivity element.
iGrafx FlowCharter 2013: Puts the textAnnotation element but reverses the association sourceRef and targetRef. Furthermore, a wrong element is used instead of the callActivity.
iGrafx Process 2013 for Six Sigma: Cf. iGrafx FlowCharter 2013
Visual Paradigm: Places the textAnnotation element a completely different subProcess (cf. #465). Furthermore, the collapsed call activity uses a wrong element (cf. #464).

For documentation purposes these are the outputs with findings:

=============================
Running test:
 Input root : D:\MIWG\bpmn-miwg-test-suite
 Output root: D:\MIWG\XPathOutput
 Application: Enterprise Architect//12.0.1207
 Test result: B.1.0-roundtrip.bpmn

ANALYSIS: Enterprise Architect//12.0.1207-B.1.0-roundtrip.bpmn
  OK     : execute: Push (id: EAPK_3A078914_46D6_48b3_A980_89A6A77DBADD)
    OK     : selectElementX; Message: //bpmn:collaboration
    OK     : selectElementX: Push (id: EAID_A0CC40B8_47A2_4273_B3F8_AE9CC4842E9D)
      OK     : selectProcessX; Message: //bpmn:process[@id=//bpmn:participant[@name='Pool']/@processRef]
      OK     : selectProcessX: Push (id: EAID_5F0E77E6_C603_445b_A076_3EBF285D9F9A)
        OK     : navigateElement; Message: bpmn:callActivity[@name='Call Activity Collapsed']
        FINDING: checkTextAssociation; Message: Text annotation 'Text Annotation' not found; Parameter: bpmn:textAnnotation[@id=../bpmn:association[@sourceRef='EAID_5AC3CA0B_A9B1_41b5_ABB2_2F397FE2520C']/@targetRef]/bpmn:text
        OK     : doExecute: Pop (id: EAID_5F0E77E6_C603_445b_A076_3EBF285D9F9A)
      OK     : doExecute: Pop (id: EAID_A0CC40B8_47A2_4273_B3F8_AE9CC4842E9D)

OK      : 3
Findings: 1

=============================
Running test:
 Input root : D:\MIWG\bpmn-miwg-test-suite
 Output root: D:\MIWG\XPathOutput
 Application: ibo Prometheus//3.6.0.0
 Test result: B.1.0-roundtrip.bpmn

ANALYSIS: ibo Prometheus//3.6.0.0-B.1.0-roundtrip.bpmn
  OK     : execute: Push (id: ibo-8b2ab198-6ff5-41c9-ae55-be6aa3f6c04c)
    OK     : selectElementX; Message: //bpmn:collaboration
    OK     : selectElementX: Push (id: ibo-6339b3c4-2737-477a-98b6-620114235c29)
      OK     : selectProcessX; Message: //bpmn:process[@id=//bpmn:participant[@name='Pool']/@processRef]
      OK     : selectProcessX: Push (id: WFP-6-2)
        FINDING: navigateElement; Message: No node found; Parameter: bpmn:callActivity[@name='Call Activity Collapsed']
        FINDING: checkTextAssociation; Message: Text annotation 'Text Annotation' not found; Parameter: bpmn:textAnnotation[@id=../bpmn:association[@sourceRef='WFP-6-2']/@targetRef]/bpmn:text
        OK     : doExecute: Pop (id: WFP-6-2)
      OK     : doExecute: Pop (id: ibo-6339b3c4-2737-477a-98b6-620114235c29)

OK      : 2
Findings: 2

=============================
Running test:
 Input root : D:\MIWG\bpmn-miwg-test-suite
 Output root: D:\MIWG\XPathOutput
 Application: iGrafx FlowCharter 2013//15.1.1.1580
 Test result: B.1.0-roundtrip.bpmn

ANALYSIS: iGrafx FlowCharter 2013//15.1.1.1580-B.1.0-roundtrip.bpmn
  OK     : execute: Push (id: )
    OK     : selectElementX; Message: //bpmn:collaboration
    OK     : selectElementX: Push (id: diagram_IDAWSPGE)
      OK     : selectProcessX; Message: //bpmn:process[@id=//bpmn:participant[@name='Pool']/@processRef]
      OK     : selectProcessX: Push (id: process_IDAQ5MJB)
        FINDING: navigateElement; Message: No node found; Parameter: bpmn:callActivity[@name='Call Activity Collapsed']
        FINDING: checkTextAssociation; Message: Text annotation 'Text Annotation' not found; Parameter: bpmn:textAnnotation[@id=../bpmn:association[@sourceRef='process_IDAQ5MJB']/@targetRef]/bpmn:text
        OK     : doExecute: Pop (id: process_IDAQ5MJB)
      OK     : doExecute: Pop (id: diagram_IDAWSPGE)

OK      : 2
Findings: 2

=============================
Running test:
 Input root : D:\MIWG\bpmn-miwg-test-suite
 Output root: D:\MIWG\XPathOutput
 Application: iGrafx Process 2013 for Six Sigma//15.0.4.1565
 Test result: B.1.0-roundtrip.bpmn

ANALYSIS: iGrafx Process 2013 for Six Sigma//15.0.4.1565-B.1.0-roundtrip.bpmn
  OK     : execute: Push (id: )
    OK     : selectElementX; Message: //bpmn:collaboration
    OK     : selectElementX: Push (id: diagram_IDA32PCC)
      OK     : selectProcessX; Message: //bpmn:process[@id=//bpmn:participant[@name='Pool']/@processRef]
      OK     : selectProcessX: Push (id: process_IDAOHYWB)
        FINDING: navigateElement; Message: No node found; Parameter: bpmn:callActivity[@name='Call Activity Collapsed']
        FINDING: checkTextAssociation; Message: Text annotation 'Text Annotation' not found; Parameter: bpmn:textAnnotation[@id=../bpmn:association[@sourceRef='process_IDAOHYWB']/@targetRef]/bpmn:text
        OK     : doExecute: Pop (id: process_IDAOHYWB)
      OK     : doExecute: Pop (id: diagram_IDA32PCC)

OK      : 2
Findings: 2

=============================
Running test:
 Input root : D:\MIWG\bpmn-miwg-test-suite
 Output root: D:\MIWG\XPathOutput
 Application: Visual Paradigm//11.1
 Test result: B.1.0-roundtrip.bpmn

ANALYSIS: Visual Paradigm//11.1-B.1.0-roundtrip.bpmn
  OK     : execute: Push (id: Definition)
    OK     : selectElementX; Message: //bpmn:collaboration
    OK     : selectElementX: Push (id: collaboration-Trisotech_Visio-_6)
      OK     : selectProcessX; Message: //bpmn:process[@id=//bpmn:participant[@name='Pool']/@processRef]
      OK     : selectProcessX: Push (id: process-ls_0623a9bd_fd34_462a_b09d_85cb5004be78)
        FINDING: navigateElement; Message: No node found; Parameter: bpmn:callActivity[@name='Call Activity Collapsed']
        FINDING: checkTextAssociation; Message: Text annotation 'Text Annotation' not found; Parameter: bpmn:textAnnotation[@id=../bpmn:association[@sourceRef='process-ls_0623a9bd_fd34_462a_b09d_85cb5004be78']/@targetRef]/bpmn:text
        OK     : doExecute: Pop (id: process-ls_0623a9bd_fd34_462a_b09d_85cb5004be78)
      OK     : doExecute: Pop (id: collaboration-Trisotech_Visio-_6)

OK      : 2
Findings: 2

dgagne commented 9 years ago

Webmeeting 8 Apr 2015 o We will split this into two issues o 1) Regarding Roundtrip interchange: where the annotations are moved from the serialization offered in the reference test case (new issues will be opened for each tools) o 2) Regarding potential clarifications required in the spec for where annotations should be serialized (this one)

mskurz commented 9 years ago

As agreed in the webmeeting,

the Issues for the tools have been created: #482, #465 and
a new issue containing a proposal for the BPMN RTF has been created: #483 As the follow-up discussions should take place in the respective issues, this issue will be closed.

bpmn-miwg / bpmn-miwg-test-suite

Text annotation is moved from process to collaboration #461