bpmn-miwg / bpmn-miwg-test-suite

BPMN 2.0 Test Cases (Models, Diagrams, Serializations) created by the BPMN Model Interchange Working Group (BPMN MIWG) at the OMG
http://www.omgwiki.org/bpmn-miwg/
Other
100 stars 73 forks source link

Reference C.1.0: Colouring esp. Pool Headers is misrepresented #878

Closed tstephen closed 1 year ago

tstephen commented 2 years ago

Considering the following image and numbering: Selection_154

  1. a Pool (id: sid-46891B57-A9D3-4A8B-AEBF-D4BA5F3961AD) with label and no color attributes
  2. a Lane (id: sid-744AEFB3-C93D-46A3-8976-EFA91784A51F) with no label and no color attributes
  3. a Pool (id: sid-5FBB6CB3-8A7C-42B5-9024-15BB2684EC57) with label and background-color set on the labelBounds
<bpmndi:BPMNLabel id="Bpmndi_BPMNLabel_HHGRALdXEeSAMrpVrpCJkg" labelStyle="Bpmndi_BPMNLabelStyle_M44qwJ1_EeS1-pEyeWEPig" color:background-color="#c2d7eb">
  1. a Lane (id: teamAssistant) with label and no color attributes
  2. a Lane (id: Approver) with label and no color attributes
  3. a Lane (id: Accountant) with label and no color attributes

I believe: a) the provided representation is correct b) the background-color on labelBounds Bpmndi_BPMNLabel_HHGRALdXEeSAMrpVrpCJkg is erroneous and should be deleted because if the intent was to color the Pool Header the bounds are too small.

Further, just for completeness, if we did want to colour both Pool headers it should be done by combining background-color on Pools (to color the whole pool) and Lanes (which will overlay the pool). Example BPMN and image attached for reference. C 1 0-colour-pool-headers C.1.0-colored-pool-headers.bpmn.txt

dgagne commented 2 years ago

1 Jun 2022 Weebmeeting o We agreed that the current C.1.0 refence model had serialization issues regarding pool coloring. o A new C.1.0 reference model will be created and circulated for validation by the group prior to replacement.