bpocallaghan / laravel-admin-starter

A Laravel Admin Starter project with Page Builder, Roles, Impersonation, Analytics, Blog, News, Banners, FAQ, Testimonials and more
http://bpocallaghan.co.za
341 stars 92 forks source link

implement spatie/laravel-permission? #27

Closed nagi1 closed 2 years ago

nagi1 commented 6 years ago

Hey, thank you so much for the great work, I wonder when can you implement spatie/laravel-permission package into the project. thanks

bpocallaghan commented 6 years ago

Hi @NagiWorks Thanks for the kind words, hope you like it or it does help you in your projects.

Honestly - I've been looking at that package before I upgraded this to laravel 5, just never got around to do it as I added 'my version' of basic roles to navigation, I realized I will sit down a bit and rewrite that part - which I still want to do :)

Things are currently a bit crazy at work why I did not do much lately, hopefully things will calm down in a few weeks and then I can start doing some upgrades to it again.

Please feel free to contribute if you want. Hopefully I can add it soon - do you need it urgently for a project or just nice to have?

nagi1 commented 6 years ago

Thanks for reply in such short notice, It would be nice to have permissions with roles.

And I would be happy to contribute, so much work but I’ll try to detracte time for it.

Thanks again for such handy and beautiful admin, hope you and others keep supporting it.

nagi1 commented 6 years ago

I need some help to understand the structure of ingrateing permissions into the project.

Plus do you plan to rewrite the whole project? Or you really did rewrite it ?

@bpocallaghan

bpocallaghan commented 6 years ago

Hi @nagi1 Sorry for the delay - sent you an invite on skype and kinda forgot about it, but I see you did not accept yet.

About the Roles & Permissions. Currently I only have roles implemented. You can create roles (blog, admin, corporate, etc) Then when you create/edit a navigation, you assign roles to the navigation. Then you can also assign roles to administrators. When user logs in - I find all the navigation matching the role(s) the user have. Example if you assign 'basic admin' (needed to login to admin) and 'analytics' to a user. When that user logs in, only the dashboard and navigation with analytics will be shown.

There is a couple of things I am thinking of doing first, and then I would like to look at permissions (so u can assign the 'edit / manage' permissions, so some users can view/read the articles, but they can not edit/create articles - and I feel when I am going to do this - I will use the spatie/permissions plugin.

Please shout if you have any questions / ideas. Thanks, Kind Regards

trianity commented 6 years ago

HI @bpocallaghan

Thanks for the good job. I am on the developing a SaaS platform, so I am involved in the Laravel. If I can suggest an enhancement, it would be good to add to the package Roles & Permissions & Groups (or Teams e.g. Teamwork @ https://github.com/mpociot/teamwork ) and Resources limit for SaaS applications. The Resources limit integrated with the Subscription package would be very useful. For example: A User can create a group and invite members for this group to use a SaaS application, but he can invite only 10 person (with a basic Subscription) and e.g. can invite 50 person (with the next level Subscription). Or in a Listing application the User can create only 3 free listings and all other listings are already paid. etc. How can I send to you a private message?

bpocallaghan commented 6 years ago

Hi @AkkuFresh Thanks, yeah, that is actually a good idea (I honesty don't really do SaaS projects, and when I do add subscriptions its more custom that does not really have the traditional tiers. Why I did not add something yet. I did look at Spate Permissions but again, never needed it before, so far the basic roles on navigation did the job :)

You can send me an invite on skype "bpocallaghan" or the same prefix @gmail.com. Unless you use other communication software?

trianity commented 6 years ago

HI @bpocallaghan , thanks for the reply, I have sent an invitation by Skype, and I also use the Zoom.us service.