search

bpocallaghan / laravel-admin-starter

A Laravel Admin Starter project with Page Builder, Roles, Impersonation, Analytics, Blog, News, Banners, FAQ, Testimonials and more
http://bpocallaghan.co.za
337 stars 92 forks source link

Impersonate Package Still Using App\User #35

Closed alhaji-aki closed 5 years ago

alhaji-aki commented 5 years ago

First and foremost I would like to thank you for this wonderful project.

The impersonate package is using the namespace App\User instead of App\Models\User which results to an error. Kindly check this out and fixx it

bpocallaghan commented 5 years ago

Hi @alhaji-aki Thank you for giving this project a try. Which version / tag are you using. Because I did some major refactoring and I actually reversed that change from \App\Models\User back to \App\User.php...

I think branch - version 1 is still using it, let me push a fix for it and then you can see which files changed. Do you perhaps prefer a fix on the impersonate package, or perhaps a search and replace will do in your project?

As you might've noticed. I am actually busy refactoring version 2 and should hopefully push some updates to it soon (just giving it a try in my current project and making some notes to help with the setup)

bpocallaghan commented 5 years ago

Update

I just did a search and replace. Please let me know if you have any issues or questions. Thank you, Happy coding!

alhaji-aki commented 5 years ago

Thank you. I have seen your update and I am pulling it. I think the problem is coming from the impersonate package. It is calling App\User instead of Appp\Models\User so in version 2 u can do it such that it uses the config(auth.model) rather.

bpocallaghan commented 5 years ago

Thanks, Aaah, good idea, will see what I can do. I think the update should solve version 1 for now (same namespace path for both)

Please shout if you have trouble or have any questions. Thanks!

alhaji-aki commented 5 years ago

You are welcome. And once again thank you for this project