search

bpozdena / OneDriveGUI

A simple GUI for OneDrive Linux client with multi-account support.
GNU General Public License v3.0
750 stars 34 forks source link

Compatibility with v2.5.x #114

Closed abraunegg closed 1 month ago

abraunegg commented 1 year ago

@bpozdena FYI within the next couple of weeks v2.5.0-alpha-0 will drop, and there are functionality differences (breaking changes) to how the client operates.

It would be worth keeping an eye on https://github.com/abraunegg/onedrive/discussions/2415 to track development progress, so that when the initial alpha code drops, you can start testing this against the GUI for compatibility.

abraunegg commented 1 year ago

@bpozdena FYI - v2.5.0-alpha-0 has dropped: https://github.com/abraunegg/onedrive/discussions/2478

abraunegg commented 1 year ago

FYI - v2.5.0-alpha1 has dropped: https://github.com/abraunegg/onedrive/discussions/2486

bpozdena commented 1 year ago

If anyone is interested in testing, there is a new branch of the GUI https://github.com/bpozdena/OneDriveGUI/tree/v1.1.0-alpha0 .

It is only compatible with the Onedrive client v2.5.0_alphaX. The path of client binary must be manually specified in the GUI settings.

Example: image

abraunegg commented 1 year ago

FYI 'alpha-2' is code complete, 'alpha-3' is in development, webhooks has been added back in, but not yet tested.

onedrive client version v2.5.0-alpha-3 -> #2520 .. a general announcement will be done once testing and uplift of webhooks is complete.

abraunegg commented 9 months ago

@bpozdena FYI 'alpha-5' is now available: https://github.com/abraunegg/onedrive/discussions/2585

This will go through my 90+ Use Case Tests per account type to shake out any issues / bugs, then will potentially push the result out as 'beta-1'

abraunegg commented 7 months ago

@bpozdena FYI , v2.5.0-rc1 is now available.

Please can you test against your GUI code that supports v2.5.x. Business Shared Items has also been totally re-written + supports syncing of shared files to a specific local location.

bpozdena commented 7 months ago

Thanks for the reminder @abraunegg . I'll do my best to dedicate some time for it in the next few days.

abraunegg commented 2 months ago

@bpozdena FYI onedrive v2.5.0-rc3 is now published. I have run this through all my use cases that I use for testing releases, and issues were fixed or test case passed.

The plan at the moment is to give this approx 1 month before the official release. Hopefully this will allow enough time for you to plan any updates / changes required for the GUI to allow for a synchronised release.

bpozdena commented 2 months ago

Perfect. Thanks for the heads up @abraunegg .

nerumo commented 1 month ago

In the logs, currently I get an error:

Client version check failed: argument of type 'int' is not iterable

I think thats related to the current version number of onedrive onedrive v2.5.0-1+np1+1.1

ps-spark commented 1 month ago

Exactly and on the GUI it shows

Screenshot from 2024-09-16 07-32-14

abraunegg commented 1 month ago

In the logs, currently I get an error:

Client version check failed: argument of type 'int' is not iterable

I think thats related to the current version number of onedrive onedrive v2.5.0-1+np1+1.1

Upgrade your GUI - please read: https://github.com/bpozdena/OneDriveGUI/releases

abraunegg commented 1 month ago

Exactly and on the GUI it shows

Screenshot from 2024-09-16 07-32-14

Upgrade your GUI - please read: https://github.com/bpozdena/OneDriveGUI/releases

nerumo commented 1 month ago

In the logs, currently I get an error:

Client version check failed: argument of type 'int' is not iterable

I think thats related to the current version number of onedrive onedrive v2.5.0-1+np1+1.1

Upgrade your GUI - please read: https://github.com/bpozdena/OneDriveGUI/releases

I'm running the latest version already: OneDriveGUI-1.1.0rc3-x86_64_fc07efaee11727db6a33c765f9cc6b76.appimage

My UI doesn't look like the one from @abraunegg . But it doesn't sync anymore. I'f I press the "Play" button, it shortly goes to green, then red again. And in the logs I got the version error

nerumo commented 1 month ago

Ok, I'm having a different problem alltogether :) I need to analyse it further.

abraunegg commented 1 month ago

@nerumo

I'm running the latest version already: OneDriveGUI-1.1.0rc3-x86_64_fc07efaee11727db6a33c765f9cc6b76.appimage

Please read: https://github.com/bpozdena/OneDriveGUI/releases

GUI version v1.0.3 is ONLY compatible with v2.4.x client.

GUI version v1.1.0rc3 is ONLY compatible with v2.5.x client.

I released v2.5.0 today ... and if you have upgraded your client, you must upgrade your GUI.

nerumo commented 1 month ago

thanks @abraunegg, I am running those versions (2.5.0-1+np1+1.1 and 1.1.0rc3). Ok, my problem of not syncing was caused by the sync_business_shared_folders option. I thought it was related to the Client version check failed: argument of type 'int' is not iterable. After removing the sync_business_shared_folders, both seam to work now.

Thanks for your support. @bpozdena regarding the sync_business_shared_folders. It is documented and it's was clear to me on how to resolve it. I guess there's a reason why you don't automatically remove the sync_business_shared_folders option if it's set to false?

abraunegg commented 1 month ago

@nerumo

After removing the sync_business_shared_folders, both seam to work now.

Please ensure you read the updated documentation regarding Business Shared Folders .... I hope you have fixed your local & online data before re-running the client ........

image

Please read: https://github.com/abraunegg/onedrive/blob/master/docs/business-shared-items.md

nerumo commented 1 month ago

I actually did read it. Since I'm not using any onedrive for business, I did not think that this will apply to me. That's why I'm asking my question: why do I need to do this even though I'm not using onedrive for business?

bpozdena commented 1 month ago

I already patched it. I'll just need to run a few tests and then release the AppImage.

ps-spark commented 1 month ago

Exactly and on the GUI it shows Screenshot from 2024-09-16 07-32-14

Upgrade your GUI - please read: https://github.com/bpozdena/OneDriveGUI/releases

Hi @abraunegg,

Thank you. I only checked the releases but not the pre-releases :( I guess, we need GUI v1.1.0rc3 for client v2.5.0-1+np1+1.1.

Screenshot from 2024-09-16 09-09-34

ps-spark commented 1 month ago

thanks @abraunegg, I am running those versions (2.5.0-1+np1+1.1 and 1.1.0rc3). Ok, my problem of not syncing was caused by the sync_business_shared_folders option. I thought it was related to the Client version check failed: argument of type 'int' is not iterable. After removing the sync_business_shared_folders, both seam to work now.

Thanks for your support. @bpozdena regarding the sync_business_shared_folders. It is documented and it's was clear to me on how to resolve it. I guess there's a reason why you don't automatically remove the sync_business_shared_folders option if it's set to false?

It is recommended to backup your OneDrive config directory, delete it and set it up again. There are some changes in the config files. The old config files won't work with the new version out of the box.

bpozdena commented 1 month ago

Please test the latest OneDriveGUI v1.1.0 AppImage and report any other issues here.

nerumo commented 1 month ago

Tested 1.1.0. It works, no more warning/errors in the logs. Thanks

And thanks @abraunegg for the performance improvements, much faster than before

bpozdena commented 1 month ago

Closing as completed. Please create new bug reports for any new issues.