search

bpr / vla

Variable length arrays for Nim
Other
17 stars 1 forks source link

Some bug fixes & minor changes #4

Closed fengkehh closed 3 years ago

fengkehh commented 3 years ago

Hello,

I fixed some bugs and hopefully didn't introduce any other breakages for VLA. From most important to least important:

  1. Added Windows compatibility.
  2. Fixed and tested asOpenArray argument passing.
  3. Added unit tests to check VLA value read/write. It bothers me that the counts from the original test are actually different but at least the read/write value comparison passes.
  4. Updated project structure to have a src directory.
  5. Updated unit tests to use the unittest suite.
  6. Now using config.nims. However nimble test doesn't seem to actually pick up the compiler flags? No ideas why. It works on my other libraries.
bpr commented 3 years ago

LGTM!

Thanks for the PR