search

bpruitt-goddard / vscode-mermaid-syntax-highlight

Markdown syntax support for the Mermaid charting language
MIT License
92 stars 35 forks source link

Add excludes and todayMarker keywords for Gantt diagramm #101

Closed ravsii closed 1 year ago

ravsii commented 1 year ago

I've used this syntax plugin recently while developing Gantt diagramm and noticed it doesn't support excludes and todayMarker keywords. (#99)

image

excludes accepts specific dates in YYYY-MM-DD format, days of the week ("sunday") or "weekends", but not the word "weekdays":

todayMarker can be either off or have a string with styles.

todayMarker regex is a little different from others as it also captures ^ and $ from a string. This is because otherwise : will be captured as a part of Task, thus breaking highlighting.

Closes #99

bpruitt-goddard commented 1 year ago

Looks good, can you rebase off of the latest master? The PR workflow check is failing and needed a minor version bump to get it working again (#102).

ravsii commented 1 year ago

Looks good, can you rebase off of the latest master? The PR workflow check is failing and needed a minor version bump to get it working again (#102).

Sure. I'll fix the mentioned errors and update as soon as I can.

maybe I wasn't using a monospaced font at the time of sending this PR, because there was no missing ^ for me

ravsii commented 1 year ago

Should be good now @bpruitt-goddard