search

bpruitt-goddard / vscode-mermaid-syntax-highlight

Markdown syntax support for the Mermaid charting language
MIT License
98 stars 38 forks source link

Fixed erDiagram being whitespace sensitive where it shouldn't #118

Closed Logerfo closed 1 year ago

bpruitt-goddard commented 1 year ago

Looks good. Can a test or two be added to the associated test file? Perhaps one of the relationship lines can be modified to reflect the change? Note you'll need to update the commented lines afterword to ensure the caret ^ symbols line up with the proper positions. You can then validate the tests via these commands (from the root of the project) npm run convertYaml && npm test

Logerfo commented 1 year ago

@bpruitt-goddard 

C:\repos\vscode-mermaid-syntax-highlight  patch-1  ~1    20.5.0 ﴱ dev0 
npm run convertYaml && npm test

> mermaid-markdown-syntax-highlighting@1.5.3 convertYaml
> node build/ConvertYaml.js

> mermaid-markdown-syntax-highlighting@1.5.3 test
> vscode-tmgrammar-test 'tests/**/*.test.{mermaid,md}'

ERROR no test cases found
bpruitt-goddard commented 1 year ago

Any chance you are on windows? I think there is a bug on Windows with the test library that is fixed by changing the quotes on the glob pattern. Can you try making this change here in package.json and see if that picks up the tests?

"test": "vscode-tmgrammar-test \"tests/**/*.test.{mermaid,md}\""
Logerfo commented 1 year ago

@bpruitt-goddard what do you think?