Closed CatBraaain closed 7 months ago
and support embed mermaid in markdown
I like the comment toggling and the embedded mermaid in markdown support, but I worry that the bracket matching/autoclosing will give issues. Consider the relationship syntax in ER diagrams. This change will make it less clear that they are valid. For example I'm seeing these brace closing errors in the ER test file:
A similar problem happens when trying to create new relationships - the bracket is attempted to autoclose ,which is not relevant for the relationship. Could we remove the brace functionality from here?
Thanks for reviewing. After receiving your feedback, I found some similar problems in curl bracket and square bracket.
I removed some features what I'm not sure it affects any problems.
The PR looks good, there are just some prettier issues in a file. Can you fix these before merge?
Checking formatting... [warn] syntaxes/mermaid.tmLanguage-markdown.yaml [warn] Code style issues found in the above file. Run Prettier to fix. Problem running prettier with --check */.{js,yaml,md}
Thanks for reviewing.
I ran npx prettier --write syntaxes/mermaid.tmLanguage-markdown.yaml
and commit it again.
Thanks to you, I'm glad I succeeded my first pull request.
Awesome job on your first PR! Thanks for picking this project to contribute to!
Add language configuration and support features bellow
Code snippets https://code.visualstudio.com/api/language-extensions/language-configuration-guide
Test
I'm very new to pull request, I welcome any feedback.