bpruitt-goddard / vscode-mermaid-syntax-highlight

Markdown syntax support for the Mermaid charting language
MIT License
98 stars 37 forks source link

Fix Github Action Deployment #139

Closed bpruitt-goddard closed 5 months ago

bpruitt-goddard commented 5 months ago

The github action for performing a deployment was triggering on a pull request merge. But this was being done within the context of the source branch, which does not have access to the repository's secrets. Namely the access token for deploying a new version of the extension. Instead of basing this action on the PR merge, this new approach bases on a push to the master branch, which should always operate within the context of someone with access to the secrets. See this github discussion. This shouldn't change when the deployments happen, it should simply allow the action to have access to the necessary secret.