search

bpruitt-goddard / vscode-mermaid-syntax-highlight

Markdown syntax support for the Mermaid charting language
MIT License
98 stars 37 forks source link

Convert grammars from yaml to json when prepublish #44

Closed vitaliy-guliy closed 3 years ago

vitaliy-guliy commented 3 years ago

Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com

Why not to remove mermaid.tmLanguage.json file at all and generate it when installing dependencies?

It allows to have the actual .json file with the latest changes in .yaml (what if something pushed without updating .json?). User just can run npm install && vsce package and be sure that everything i up-to-date.

I just worked on building this extension and on Mermaid Markdown preview and noticed ,that the second one has a dedicated command to be launched when installing dependencies https://github.com/mjbvz/vscode-markdown-mermaid/blob/master/package.json#L51

jnnnnn commented 3 years ago

Looks good to me

bpruitt-goddard commented 3 years ago

Nice job! I didn't realize there was a prepublish command 👍 .