bpruitt-goddard / vscode-mermaid-syntax-highlight

Markdown syntax support for the Mermaid charting language
MIT License
92 stars 36 forks source link

modify "contributes.languages.id" in order to apply the grammar to .mmd files correctly #63

Closed tomoyukim closed 2 years ago

tomoyukim commented 2 years ago

Hello. Thank you for providing really great extension! I found the grammar isn't applied correctly in a .mmd file. It seems to be caused by the capital letter in the language ID. I could confirm it worked fine at my local. I'm glad if this PR helps to improve this package.

rngtng commented 2 years ago

Full support this, find the spec here: https://code.visualstudio.com/docs/languages/identifiers

Looking into other plugins, they align to this too, e.g.

rngtng commented 2 years ago
Screenshot 2022-02-22 at 21 28 21

^^ Test the fix locally, can confirm it works :)

rngtng commented 2 years ago

@bpruitt-goddard can you pls have a look at this?

rngtng commented 2 years ago

Thanks a lot