search

bpruitt-goddard / vscode-mermaid-syntax-highlight

Markdown syntax support for the Mermaid charting language
MIT License
98 stars 37 forks source link

Support curly braces #92

Closed mattorp closed 1 year ago

mattorp commented 1 year ago

Adds support for curly braces:

    ```{ .mermaid caption="Title" #fig:graph}
    ...


Just a draft. I haven't tested extensively, but I thought I'd share since I needed the functionality myself
bpruitt-goddard commented 1 year ago

Looks good, aside from the comment/fix and small merge conflict. Is the intention to ever add highlighting to these pandoc options? Or is the current approach sufficient to have them not break mermaid highlighting? Ideally, I'd like to avoid having to also add support for highlighting pandoc options in this project, but I don't think there is a way to support having multiple syntax highlighters supported on the same line.

jorlando-tuik commented 1 year ago

Thank you very much for taking the time to look at the PR. I would agree with you that there is marginal return in highlighting the pandoc specific markup. I wouldn't be pushing for the investment when the real value is delivered by keeping things simple.

Thank You, -Jamie

From: Brian Pruitt-Goddard @.> Sent: Thursday, November 2, 2023 5:19 PM To: bpruitt-goddard/vscode-mermaid-syntax-highlight @.> Cc: Jamie Orlando @.>; Comment @.> Subject: Re: [bpruitt-goddard/vscode-mermaid-syntax-highlight] Support curly braces (PR #92)

Looks good, aside from the comment/fix and small merge conflict. Is the intention to ever add highlighting to these pandoc options? Or is the current approach sufficient to have them not break mermaid highlighting? Ideally, I'd like to avoid having to also add support for highlighting pandoc options in this project, but I don't think there is a way to support having multiple syntax highlighters supported on the same line.

— Reply to this email directly, view it on GitHubhttps://github.com/bpruitt-goddard/vscode-mermaid-syntax-highlight/pull/92#issuecomment-1791552903, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A664GUPDN6GAF74UIUZRFHDYCQE7DAVCNFSM6AAAAAAURJG2ISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJRGU2TEOJQGM. You are receiving this because you commented.Message ID: @.***>

bpruitt-goddard commented 1 year ago

Sounds good. I think we can merge it as-is after the conflicts and comment are resolved :shipit:

jorlando-tuik commented 1 year ago

Sent my own PR addressing the comments https://github.com/bpruitt-goddard/vscode-mermaid-syntax-highlight/pull/119

bpruitt-goddard commented 1 year ago

Closing this as it was fixed in #119.