Keyword logic - Githubissues

bpsm / edn-java

a reader for extensible data notation

Eclipse Public License 1.0

100 stars 24 forks source link

Keyword logic #8

Closed mikera closed 12 years ago

mikera commented 12 years ago

Added useful features to Keyword for better performance:

pre-computed hashcode (matching Clojure's keyword hash)
equality checking using object identity (since keywords are interned)

bpsm commented 12 years ago

fast path in compareTo looks good.
Keyword already implements equals() using Object identity because it inherits Object.equals() which does exactly this.
Since Keywords are interned, Object.hashCode(), which is the same as System.identityHashCode() already does what we need.

mikera commented 12 years ago

OK your comments providing you don't think it is worth replicating the Clojure keyword hashes (can't actually see a use case where this is particularly useful).

What's the best way to handle this - shall I revert the other two commits?

bpsm commented 12 years ago

I've already cherry-picked b33ad87, so I think we can just close the pull request.