bptlab / TracEX

This bachelorproject focuses on event log extraction from patient journeys using large-language models.
5 stars 5 forks source link

Implementation of new app: Trace Comparator #103

Closed tkv29 closed 7 months ago

tkv29 commented 7 months ago

This PR introduces the UI for the Trace Comparator feature, which allows users to compare patient journeys and ground truth traces. The implementation includes the following:

This PR aims to close #71, which tracks the implementation of the Trace Comparator UI.

tkv29 commented 7 months ago

I can't solve the pylint error. Anyone has an idea?

nils-schmitt commented 7 months ago

As Pylint only points out one ungrouped-imports, i guess it's becuase of redirect from django.shortcuts being imported before pm4py and afterwards importing all the other django.smth. grafik

tkv29 commented 7 months ago

Ahh thx! I looked at the wrong view lol

thangixd commented 7 months ago

I pulled it and looked at the code. Apart from the few little things that Frederic has already mentioned, I have nothing to add. Great work

if there a upcoming changing like another approach with for example changing the approach instead of overriding the post method. I will review it again

tkv29 commented 7 months ago

I think the trace_comparator module is not deleted yet. Do we still need it, now that the comparator is a separate app? When selecting a patient journey for comparison, the filter view is also displayed. Does deselecting some event types or locations have any impact on the comparison? If it doesn't, maybe we shouldn't display the options.

these changes are implemented