bptlab / TracEX

This bachelorproject focuses on event log extraction from patient journeys using large-language models.
5 stars 5 forks source link

Feature/97 adapt test mode presentation new #107

Closed soeren227 closed 6 months ago

soeren227 commented 7 months ago

Closes #97 .

Expands presentation/test mode. Instead of running the pipeline it loads a patient journey from the database. Shows a pseudo progress according to the modules in the configuration. In order for it to work you need to:

tkv29 commented 7 months ago

Functionality lgtm, gj!

To the code reviewers: you have to checkout the new branch (which has the same name just with "-new"), took me a while to understand why it didnt work lol

tkv29 commented 7 months ago

Speed is okay, in case we just have to change some numbers, so no problem from my side

PitButtchereit commented 7 months ago

I've also noticed this column in the final dataframe and from the view of the listeners this seems confusing. Why is it there?

Bildschirmfoto 2024-04-22 um 10 27 07

soeren227 commented 7 months ago

I'll have to look into why the extra column appeared. Its not there on main? As to your suggestion to not merge this branch with main: I can see you argument, that it would add some lines of code that wouldn't be needed in "production", but e.g. when testing UI changes or other elements where one does not need openai calls it can be pretty helpful to have a test mode. Maybe we can put this to a vote?

PitButtchereit commented 7 months ago

This column is also there on main for me.

soeren227 commented 7 months ago

Yeah, I just checked aswell. I guess it makes sense in terms of a PJ id.

tkv29 commented 7 months ago

@nils-schmitt maybe you have more information

nils-schmitt commented 7 months ago

Yes, thats the ID, needed fit Disco or similar and to enumerate the different traces in the eventlog. The Name is due to the naming conventions in Disco, i think

tkv29 commented 6 months ago

I will close this pull request due to our group decision. The branch will still be open for further use.