Feature/105 cohort filter all trace view

[soeren227]

Closes #105.

This PR adds an evaluation view in which the contents of the database can be scrutinized. You can filter based on activity (like in ResultsView) and based on Cohort (gender, age, origin, condition, preexisting_condition).

For this to work and for you to test you need to

1. have sufficient database entries preferably with complete cohort information (you get this by generating pjs with the generator or editing existing cohort information)
2. connect traces to cohorts with a 1:1 mapping

PM me if you run into trouble :D

[tkv29]

Functionality looks good, gj! Some remarks regarding the design:

• Could you add a space between the label and the slide please so there is no overlay:

  

• I think using Events instead of Activities in "Filter based on Activities" is more fitting

• Maybe it would look better if you put a divider between the Filter Activites and Filter Cohorts (https://www.w3schools.com/howto/howto_css_dividers.asp)

• why is the select/deselect button only for the origin, I guess the naming of the button should be more declarative, so the user know that its only for the origin

  

[soeren227]

Functionality looks good, gj! Some remarks regarding the design:

• Could you add a space between the label and the slide please so there is no overlay:

• I think using Events instead of Activities in "Filter based on Activities" is more fitting
• Maybe it would look better if you put a divider between the Filter Activites and Filter Cohorts (https://www.w3schools.com/howto/howto_css_dividers.asp)
• why is the select/deselect button only for the origin, I guess the naming of the button should be more declarative, so the user know that its only for the origin

Would you prefer a change in labeling (e.g "Select/Deselect all Origin Options), the addition of similar buttons for all other choices or the removal of that button and functionality?

Thanks for the feedback on everything else 👍

[tkv29]

Functionality looks good, gj! Some remarks regarding the design:

• Could you add a space between the label and the slide please so there is no overlay:

• I think using Events instead of Activities in "Filter based on Activities" is more fitting
• Maybe it would look better if you put a divider between the Filter Activites and Filter Cohorts (https://www.w3schools.com/howto/howto_css_dividers.asp)
• why is the select/deselect button only for the origin, I guess the naming of the button should be more declarative, so the user know that its only for the origin

Would you prefer a change in labeling (e.g "Select/Deselect all Origin Options), the addition of similar buttons for all other choices or the removal of that button and functionality?

Thanks for the feedback on everything else 👍

Removing the button and using a selection box like this for every cohort attribute would be nice:

Afaik u also for the select/deselect all JS, its also possible to this with a checkbox This would be probably helpful: https://stackoverflow.com/questions/14260428/how-to-select-and-deselect-all-options-in-a-select-box

[tkv29]

Is it possible to copy the code of the download button, to download the xes based on the cohort filters?

[soeren227]

Is it possible to copy the code of the download button, to download the xes based on the cohort filters?

it should be possible, but i'd need to talk to @thangixd about it since he created the logic behind the download button.

[thangixd]

Is it possible to copy the code of the download button, to download the xes based on the cohort filters?

it should be possible, but i'd need to talk to @thangixd about it since he created the logic behind the download button.

Should be. Can u give me a brief description what exactly u want?

[tkv29]

Good job, some points I noticed:

• When accessing the evaluation page, could you remove the decimals of the age:

• could you please add some spacing between the cohorts button / cohorts table and the dfg

• is it possible to put origin in the same row as the other filters? Seems a little weird for me that only origins is separated, or does this have a reason?

• the include none values is missing for condition:

• can you change that include non values is always being the last choice please

• could you please check if the include non values are working as intended? e.g. even though the include non checkbox of the age filter is not ticked, its still using the traces where the age is None

[tkv29]

Could you please rename "Gender" to "Sex", during the workshop presentation it was remarked that its the social gender and the biological sex

[tkv29]

as mentioned in the weekly: could you drop the metrics columns

[thangixd]

This pr also closes #131

[soeren227]

The last commit implements changes to accomodate your suggestions. Please check if everything is in order now @tkv29 @nils-schmitt Thanks :)

Edit: You need to migrate once since i needed to change gender to sex in the Cohort model