Refactor/133 tracex pj generator

bptlab / TracEX

This bachelorproject focuses on event log extraction from patient journeys using large-language models.

5 stars 5 forks source link

Refactor/133 tracex pj generator #142

Closed PitButtchereit closed 6 months ago

PitButtchereit commented 6 months ago

I've refactored the tracex app and patient journey generator app. Since the tracex app contains functionality that is used in many different files, I've also changed some things outside of the supposed scope.

Remaining: Find a design for function buttons and menu buttons.

tkv29 commented 6 months ago

@PitButtchereit since you did more then the discussed scope did u also informed all other refactoring app owner about this?

tkv29 commented 6 months ago

since u mentioned the button design is still remaining, this still need to be removed I guess?

tkv29 commented 6 months ago

the new button effects looks nice btw!

tkv29 commented 6 months ago

The logo in the pj generator seems quite big, could you make it smaller pls?

The link between pj generator and extraction pipeline/result is not working. After creating a pj and executing the pipeline I am getting redirected to the trace testing env
Design of buttons in the evaluation view are broken

PitButtchereit commented 6 months ago

@PitButtchereit since you did more then the discussed scope did u also informed all other refactoring app owner about this?

Absolutely!

PitButtchereit commented 6 months ago

since u mentioned the button design is still remaining, this still need to be removed I guess?

We'll discuss the design of the function button today!

PitButtchereit commented 6 months ago

This code check is now ready to review 👍

nils-schmitt commented 6 months ago

Looks good by going bover it briefly

Saw three things:

grafik Here the execution button should be disabled while execution (Trace Testing)

grafik Here a padding should be added (Trace Testing)

grafik Here the first button should be called: "Show/Hide extracted Trace from Patient Journey" (Extraction)

thangixd commented 6 months ago

Good Job!! This looks amazing!!!

thangixd commented 6 months ago

has to be fixed in main after the merge since we changed the db prompts

PitButtchereit commented 6 months ago

I'm not sure if you can rewrite the donwloadxesview like you did. I also wrote it initially like you, but I always get this error. Maybe someone else can check on a Windows computer?

Download trace and event log on the results page

I tested the functionality and it worked for me. @nils-schmitt can you test it? I will remove the deletion of the temporary file and close it. The temporary file should then be deleted once the Django server shuts down. This means we are taking up more memory, but who cares?

PitButtchereit commented 6 months ago

has to be fixed in main after the merge since we changed the db prompts

Do you know what is causing the error here?

EDIT: From what I can see on the screenshot, the traceback tells that a prompt is queried that is not even in the database. However, I don't see where this is called in the code.

nils-schmitt commented 6 months ago

Also i have no troubles with the xes downloads @PitButtchereit @thangixd

thangixd commented 6 months ago

has to be fixed in main after the merge since we changed the db prompts

Do you know what is causing the error here?

EDIT: From what I can see on the screenshot, the traceback tells that a prompt is queried that is not even in the database. However, I don't see where this is called in the code.

in the extraction app under module_patient_journey_preprocessor.py line 61

//edit: idk why but i pulled again now its gone

thangixd commented 6 months ago

everything is working now! good job pit!