Refactor validators - Githubissues

bptlab / gryphon

web-based modeler based on bpmn.io for fCM case models (to be executed by https://github.com/bptlab/chimera)

4 stars 1 forks source link

Refactor validators #70

Closed MaximilianV closed 5 years ago

MaximilianV commented 5 years ago

With this PR

The validators are moved to an own folder (they sold themselves below value and hid in helpers before :mag:)
The validators are now executed in parallel using async/await keywords. I'll need this asynchronous behavior later for the new resource task validator, which needs to call the resource manager, which in turn is, again, an asynchronous call. :dizzy_face:
Also, some code formatting was done (thanks to VS Code).

If you find places where I've withheld asyncs or awaits from the code or spoiled it too much, please point them out!

adi64 commented 5 years ago

I guess this looks fine, what you told me also makes sense. Unfortunately, I have so far managed to stay away from async / await and cannot really give a profound review, sorry :man_shrugging: