Closed marcfreiheit closed 6 years ago
Can we close this pull request without merging it? It seems that it's not of interest? 😀
Actually it is of interest, I just have not had the time yet to handle it and it seems like Björn has built a little JUnit test. We can discuss this later or simply force push to another branch if necessary.
Copy that. If you've got any questions, please let me know.
Finally looking into this. Todo:
Sorry, didn't recognized your comment. Do you have any questions I could answer?
I think currently everything is ok, except I am not yet sure how to finally include the maven dependencies. I moved them to the local maven repository, but that requires them to be installed there manually. I will have to figure something out, especially regarding the plugin structure of Scylla.
Description
Testing
This PR introduces the testing framework junit and configured Travis support. All tests can be found in
src/test/java/de/hpi/bpt/scylla/
and must have theTests
postfix. The postfix is mandatory, otherwise tests which lack this postfix will be skipped.Local Maven Repository
In addition, I've added a local maven repo to manage all plugins. You can find the repo in
src/main/resources/scylla-repository/
. I've included StatsLogging and InterfaceTesting already. Doing that, you don't have to include the jars manually. You can just pull the code and go ahead.Refactored main method of Scylla
I've refactored the main class in order that it's testable. You can now pass parameters to the main method using the following schema:
We could consider choosing a better layout. That's just my first try.
Git LFS
Since .jar-files should't be version controlled, because they are large binary files, I've activated git lfs to keep the repo clean. Git LFS is limited in storage and bandwith and we have to check if our current limits are exhaustive. If not, we have to purchase more storage and bandwith or skip git lfs and disable it.
Reladed Issues
7 should be marked as done (at least partially done) when this pull request is merged.
Steps to test or reproduce
Execute
mvn '-Dtest=de.hpi.bpt.scylla.*Tests' test
from the project directory to run all tests. That's the command executed by travis, too.Impacted Areas in Application
List general components of the application that this PR will affect:
To Do
lib/
to the local maven repository or reference them another way. Maybe some of the libraries can be found on github? Then we could add them as submodules?mvn clean test
. Don't know, why it's not working yet.