bptlab / scylla

Extensible BPMN process simulator
MIT License
19 stars 9 forks source link

Default Timetables do not work as intended #72

Closed MaximilianKoenig closed 5 months ago

MaximilianKoenig commented 5 months ago

In a global configuration with resource instances that have a default timetable assigned to them, they are not simulated to work according to the timetable, but rather work 24/7.

(Non-minimal) example: Default_Timetables_Config.zip

In the example, all resource instances that have the "Day_Shift" assigned to them as "default timetable" work 24/7. If instead the "Day_Shift" is explicitly assigned to them, they work only during the intended times.

LeonBein commented 5 months ago

In https://github.com/bptlab/scylla/blob/9739a18b7c5f6494897457190a91f39d26da2de8/src/main/java/de/hpi/bpt/scylla/parser/GlobalConfigurationParser.java#L163-L165, only defined timetables are set. If no instance timetable is defined, it should fall back to the default on, as in https://github.com/bptlab/scylla/blob/9739a18b7c5f6494897457190a91f39d26da2de8/src/main/java/de/hpi/bpt/scylla/parser/GlobalConfigurationParser.java#L130-L132