search

bpuig / laravel-subby

Laravel Plan and Subscriptions manager.
https://bpuig.github.io/laravel-subby
MIT License
102 stars 42 forks source link

changePlan -> deleteFeaturesNotInPlan Bug #130

Closed aeq-dev closed 2 years ago

aeq-dev commented 2 years ago

Hello @bpuig Thanks for this great package, I noticed that deleteFeaturesNotInPlan doesn't delete features not in plan we change to. I fix it by updating this :

// Retrieve current features that are not related to a plan
$featuresWithPlan = $this->features()->withoutPlan()->get();

To :

// Retrieve current features that are not related to a plan
$featuresWithPlan = $this->features()->get();
bpuig commented 2 years ago

Fixed in #136 . Thanks