Features are not returned according to the `sort_order`

bpuig / laravel-subby

Laravel Plan and Subscriptions manager.

https://bpuig.github.io/laravel-subby

MIT License

102 stars 42 forks source link

Features are not returned according to the `sort_order` #91

Closed boryn closed 2 years ago

boryn commented 3 years ago

Actually, I have just discovered that features and features in relationships are not returned in the order set by the sort_order column.

bpuig commented 3 years ago

Yes, it's your duty to order them on your query. If package orders them it may interfere with user's custom selects and orders.

boryn commented 3 years ago

I think, maybe it would be worthy to insert a sentence about it in the docs? Seeing the sort_order column I mistakenly assumed the sorting is handled by the library.

bpuig commented 2 years ago

Fixed 2624be2a21875c275afa16e2865a98b84f87db5e