Open bqth29 opened 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
6194a9e
) to head (3137751
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
π¬ Pull Request Description
Some parameters of the optimization-related functions of backend classes were using keyword-only parameters in a way that seemed quite arbitrary. This has been homogenized by putting all parameters as keyword-only, expect the optimization domain (
domain
) if applicable.The
domain
parameter also no longer has a default value (forminimize
,maximize
andoptimize
functions) to encourage users explicitely defining the optimization domain of their choice to avoid confusion.βοΈ Check list
Before you open the pull request, make sure the following requirements are met.
π New features
None
π Bug fixes
None
π£ Supplementary information
Defining these parameters as keyword-only may have introduced breaking changes for users directly calling the impacted backend classes using a version <= 1.2.1.