search

bquast / rnn

Recurrent Neural Networks in R
https://qua.st/rnn
73 stars 28 forks source link

finance demo app #2

Closed DimitriF closed 8 years ago

bquast commented 8 years ago

Thanks, this looks good except that the file mode for all files has changed, I'm not sure if that is a good idea. Why is that?

DimitriF commented 8 years ago

The function wasn't working, I change it in the last commit. For the files mode, I put everybody to 777 that's the reason. I need more experience with git, it's still kind of a mystery how it's working for me.

bquast commented 8 years ago

yeah, git is hard. but do you think it is necessary to chmod? otherwise I would rather keep them as they are.

git

bquast commented 8 years ago

oh and a small note. usually you end a code file with an empty line, its not imports any more but github starts displaying red things if you dont

http://stackoverflow.com/questions/2287967/why-is-it-recommended-to-have-empty-line-in-the-end-of-file

DimitriF commented 8 years ago

I agree on this one, Is it possible to close this pull request so I can put my shit together and come back with something cleaner?

bquast commented 8 years ago

yeah of course. If I were you I would follow the XKCD advice, just download a fresh copy and copy the files back in