search

bquast / rnn

Recurrent Neural Networks in R
https://qua.st/rnn
73 stars 28 forks source link

finance demo app #3

Closed DimitriF closed 8 years ago

DimitriF commented 8 years ago

I hope this one will be better

bquast commented 8 years ago

Great job! Thanks

bquast commented 8 years ago

Ok it won't merge because there is an error:

0.09schecking examples ... ERROR
Running examples in ‘rnn-Ex.R’ failed
The error most likely occurred in:
> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Name: run.finance_demo
> ### Title: Demo app on finance data
> ### Aliases: run.finance_demo
> 
> ### ** Examples
> 
> run.finance_demo()
Error in loadNamespace(name) : there is no package called ‘shiny’
Calls: run.finance_demo ... tryCatch -> tryCatchList -> tryCatchOne -> <Anonymous>
Execution halted checking dependencies in R code ... WARNING
'::' or ':::' import not declared from: ‘shiny’
bquast commented 8 years ago

I think all that needs to be added (to run.finance_demo.R) is:

#' @importFrom shiny runApp
DimitriF commented 8 years ago

now the shiny package is missing in the description file I think

bquast commented 8 years ago

you're right

bquast commented 8 years ago

I continued running forever on the last build. I suspect this is the because the run.finance_demo() example never ends.

I think that example should be encapsulated by dontrun().

http://stackoverflow.com/questions/12038160/how-to-not-run-an-example-using-roxygen2

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-6.4%) to 86.111% when pulling 8956f6f886a9c5bb6b8609c201557a8878cff7fa on DimitriF:master into 26edcc8f3411a10ace62042b2e6949e734fec075 on bquast:master.