search

bquast / rnn

Recurrent Neural Networks in R
https://qua.st/rnn
73 stars 28 forks source link

Problem with negative number #7

Closed vinhqdang closed 8 years ago

vinhqdang commented 8 years ago

Hello

I noticed that, if I do int2bin and bin2int consequently on negative number, I will get a positive number afterwards.

While the mechanism of converting is understandable, I think it would raise confusion, especially the function name int2bin suggests that it should work with int, not unsigned int only.

bquast commented 8 years ago

Thanks, that is a good point. As I mentioned before, these functions were included for the PoW bit-by-bit summation. They're no longer part of the core functionality and will eventually be removed.

vinhqdang commented 8 years ago

Thanks a lot,

Btw, could RNN works with factor variables? For instance, X1 and X2 are not numeric but factor variables? — Best Regards

Vinh

On Jun 1, 2016, at 11:34 AM, Bastiaan Quast notifications@github.com wrote:

Thanks, that is a good point. As I mentioned before, these functions were included for the PoW bit-by-bit summation. They're no longer part of the core functionality and will eventually be removed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bquast/rnn/issues/7#issuecomment-222941873, or mute the thread https://github.com/notifications/unsubscribe/AEqh6HnmsuYboE_xeJtkilmJXMwOHZXUks5qHVIvgaJpZM4IrWXx.

bquast commented 8 years ago

It would be great if you could ask that question on www.stackoverflow.com and paste the link here, that way others can also benefit from the answer.

vinhqdang commented 8 years ago

Oops, sorry, I will do that. — Best Regards

Vinh

On Jun 1, 2016, at 11:38 AM, Bastiaan Quast notifications@github.com wrote:

It would be great if you could ask that question on www.stackoverflow.com http://www.stackoverflow.com/ and paste the link here, that way others can also benefit from the answer.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bquast/rnn/issues/7#issuecomment-222942684, or mute the thread https://github.com/notifications/unsubscribe/AEqh6M8syZE65nUm4DZb3kvk-9mj2Wmcks5qHVL7gaJpZM4IrWXx.

vinhqdang commented 8 years ago

Hi

The question is there

http://stackoverflow.com/questions/37742290/using-rnn-in-r-with-factor-variable

bquast commented 8 years ago

Great, it will try to answer it on Sunday I am travelling now.

vinhqdang commented 8 years ago

Thanks there

bquast commented 8 years ago

Hi Vinh,

I just had a look at your question, but it seems to have been closed, it looks like this is because it didn't include a sort of working in progress.

You could edit the question to create some sample data and then run it and say: I get this error... does that make sense?

vinhqdang commented 8 years ago

Oops, I did not get notifications about your answer. I posted a new one here:

http://stackoverflow.com/questions/38334076/using-rnn-in-r-with-factorial-input-variables

vinhqdang commented 8 years ago

Hi,

Thanks for your answer on stackoverflow.

Could you take a look at https://github.com/bquast/rnn/issues/6 as well?