bquistorff / synth_runner

A tool to run a pool of synthetic controls, conduct inference, and produce visualizations.
42 stars 27 forks source link

nested option in synth #16

Closed hwanoong closed 6 years ago

hwanoong commented 6 years ago

Hi Brian,

Thank you very much for providing this package to us. My problem is the optimal weights for the synthetic control group are different from using "synth" and "synth_runner".

I guess the reason is synth_runner does not use "nested" option (correct?) as I see pre_rmpse is way much larger than when I use "synth" command. Can you incorporate"nested" option in your package?

It would be great if users can have "nested" option as some cases matching pre-trends is poor without this.

Best, Hwanoong

Preliminaries

Before submitting an issue, please check (with x in brackets) that you:

Expected behavior and actual behavior

Described what you expected to see and what you actually see

Steps to reproduce the problem

Please include a minimal, complete, and verifiable example. If possible, use system-provided or generated data. Otherwise please link to data so that the example can be verified by others. Format the code with an initial and final line of three backticks(`) for readability (see GitHub's markdown formatting)

System information

bquistorff commented 6 years ago

You already can. Just pass in 'nested' and it will get passed on to synth.