bquistorff / synth_runner

A tool to run a pool of synthetic controls, conduct inference, and produce visualizations.
42 stars 27 forks source link

Problem with example "smoking" #20

Closed Liviayi closed 6 years ago

Liviayi commented 6 years ago

Preliminaries

Before submitting an issue, please check (with x in brackets) that you:

Expected behavior and actual behavior

Described what you expected to see and what you actually see

Steps to reproduce the problem

Please include a minimal, complete, and verifiable example. If possible, use system-provided or generated data. Otherwise please link to data so that the example can be verified by others. Format the code with an initial and final line of three backticks(`) for readability (see GitHub's markdown formatting)

System information

Liviayi commented 6 years ago

I am using Stata IC 14.2. I have trouble running the examples in the help file. After "sysuse smoking", my smoking file actually look like the following. There is no "state" or "year" variable. Do you have any idea why that is the case?

capture

bquistorff commented 6 years ago

SSC changed the smoking.dta file in synth. You can get the original version from my repo here.

bquistorff commented 6 years ago

Oddly, none of the versions/dates in the synth.pkg, synth.ado, synth.sthlp changed. But sometime when I cached the install that is in this repo (2016-08-31) and this issue they swapped the data. It appears that the newer network package uploaded a dataset with the same name and it overwrote the one form synth. I've contacted the SSC about this.

bquistorff commented 6 years ago

The synth package has been updated with the correct dataset and its name is now synth_smoking. I've fixed the help and main README.md