br101 / pingcheck

Check connectivity of interfaces in OpenWRT
GNU General Public License v2.0
51 stars 15 forks source link

Use ulog from libubox #7

Closed zhaojh329 closed 6 years ago

zhaojh329 commented 6 years ago

Signed-off-by: Jianhui Zhao jianhuizhao329@gmail.com

br101 commented 6 years ago

Hi and thanks for your contribution! Unfortunatly I can not accept it... I use LOG_INF, LOG_ERR, ... macros in many of my projects and got so used to them that I don't want to change them for one project only. If you want the log to go thru ulog you could change log.c to do that. That would be fine with me, allthough I do not see the big benefit either... What's your reason anyways?

zhaojh329 commented 6 years ago

OK. When do you update feed for openwrt?

br101 commented 6 years ago

OK will do now, thanks anyways

br101 commented 6 years ago

https://github.com/openwrt/packages/pull/5699