br1ghtyang / asterixdb

Automatically exported from code.google.com/p/asterixdb
0 stars 0 forks source link

Code review for the fix of issue 460 #477

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Purpose of code changes on this branch:
Fixing issue 460. The changes include Asterix and Hyracks codeases. Both 
branches are under the same name: salsubaiee/master_fix_asterix_issue_460

Specifically, here are the links of the asterix related changes:
1) http://code.google.com/p/asterixdb/source/detail?r=9d776bf3c894
2) http://code.google.com/p/asterixdb/source/detail?r=904d2501adb2
3) http://code.google.com/p/asterixdb/source/detail?r=ee5bf5231aac
4) http://code.google.com/p/asterixdb/source/detail?r=5800c16c90fe
5) http://code.google.com/p/asterixdb/source/detail?r=b8b78fd09216

and here are Hyracks related changes:
1) http://code.google.com/p/hyracks/source/detail?r=cb046721e515
2) http://code.google.com/p/hyracks/source/detail?r=10aa99d05329
3) http://code.google.com/p/hyracks/source/detail?r=4634d0fcb4d8
4) http://code.google.com/p/hyracks/source/detail?r=d0930c6769c3
5) http://code.google.com/p/hyracks/source/detail?r=04a7a5884c8d

When reviewing my code changes, please focus on:
Indexes utilize all the available IO devices. 
I added Zack because I want to him look at the changes related to the local 
resource repositories since he is familiar with that part of the code.

After the review, I'll merge this branch into:
/master

Original issue reported on code.google.com by salsuba...@gmail.com on 26 May 2013 at 11:18

GoogleCodeExporter commented 8 years ago
Sattam,

   There are multiple versions of some files (it's hard to track all deltas of a file). Can you send me two change lists (asterixdb and hyracks) using http://code.google.com/p/asterixdb/wiki/CodeReviewsWithRietveld?
   The specific command is:
   git cl upload origin/master -r buyingyi@gmail.com --send-mail -m "Code Review on xxx"

   It should be easy and automatic. Normally I just use 1-2 mins to send out that...  Can you let me know what issue you run into last time?
   Thanks!

Yingyi

Original comment by buyingyi@gmail.com on 27 May 2013 at 3:20

GoogleCodeExporter commented 8 years ago

Original comment by buyingyi@gmail.com on 28 May 2013 at 8:40