br1ghtyang / asterixdb

Automatically exported from code.google.com/p/asterixdb
0 stars 0 forks source link

Code clean for the fix of issue 349 #502

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
The fix for issue 349 is not ideal and needs to be revisited. 

1) We should be able to abstract common parts of code between HDFSAdapter and 
HDFSReadOperator. Currently the code is duplicated. Proposal is to add a 
utility class that exposes a method:-
   Map<String, Queue<InputSplit>> getSchedule(JobConf conf) 

2) The adapter interface configure method has been changed to accept a 
Map<String,Object> instead of Map<String,String>. This change was required for 
HDFSAdapter and should not be cascaded to other Adapters implementing the same 
interface.

Original issue reported on code.google.com by RamanGro...@gmail.com on 4 Jun 2013 at 9:13

GoogleCodeExporter commented 8 years ago
Here is my proposal for IAdapterFactory:
IAdapterFactory{

void configure(Map<String, String> configurations, IMetaDataProvider mp);

AlgebricksConstraint getConstraint();

IAdapter createAdapter(IHyracksTaskContext ctx);
}

The bottom line is that adapters should not be constructed in CC/compiler.   
The read-only information for adapters should always be stored in the 
corresponding factories, which are serialized to NCs at the runtime.

Original comment by buyingyi@gmail.com on 4 Jun 2013 at 9:19

GoogleCodeExporter commented 8 years ago
fixed in branch raman/master_feeds_merge.

Original comment by RamanGro...@gmail.com on 16 Nov 2013 at 2:52