br1ghtyang / asterixdb

Automatically exported from code.google.com/p/asterixdb
0 stars 0 forks source link

Transaction Log Dir is not being configured in the correct manner. This breaks managix delete/backup/restore operations #506

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Transaction log directory is being taken from asterix-configuration.xml in the 
following way:-
       <property>
                <name>txn.log.directory</name>
                <value>asterix_logs/</value>
                <description>The directory location for transaction logs. (Default =
                        "asterix_logs/")
                </description>
        </property>

I think, this is not good because of the following reasons:-

asterix-configuration.xml is sort of a hidden configuration that end-user may 
not care to change at all. We will end up picking the default value:- 
asterix_logs.  This path would be created under the working directory from 
where the JVM was launches. In Asterix, it is recommended to have the working 
directory be on NFS so that we ship binaries just once. Having the transaction 
log directory default to an NFS path is not good for obvious reasons. 

In addition, this change also breaks the existing logic of deleting and taking 
a back up of an instance. Earlier, we had this directory configured in cluster 
xml and was being removed/backed up by Managix. Although Managix can change to 
take the value from the asterix-configuration.xml, it is not the right way 
because of reasons described before. Further, this would prohibit multiple NCs 
(each needs to have a different value) on a single machine, which is not the 
common case, but should still be supported. 

taking ownership.

Original issue reported on code.google.com by RamanGro...@gmail.com on 5 Jun 2013 at 9:27

GoogleCodeExporter commented 8 years ago

Original comment by vinay...@gmail.com on 5 Jun 2013 at 7:05

GoogleCodeExporter commented 8 years ago
fixed and merged into master.

Original comment by RamanGro...@gmail.com on 5 Jun 2013 at 11:40