search

bra1n / judgebot

Discord Bot for Magic: The Gathering / Judge related content
https://discord.com/api/oauth2/authorize?client_id=240537940378386442&permissions=274878187520&scope=applications.commands%20bot
GNU General Public License v3.0
34 stars 17 forks source link

Redirect CR links to Yawgatog #179

Closed lunakv closed 2 years ago

lunakv commented 2 years ago

Replaces #148.

Issue

While the annotated MTR and IPG are still maintained on the MagicJudges.org site today, the hyperlinked CR has apparently not been touched for over two years now. This leads to problems when the bot cites a correct, up-to-date rule, but its link leads to an outdated or nonexistent link on the site.

Fix

This PR replaces MagicJudges.org with Yawgatog as the provider for links regarding the CR. Yawgatog is a great ongoing project that creates a very usefully hyperlinked website from the CR, and it tends to update with new CR releases in a matter of days.

I also replaced the thumbnail icon with Yawgatog's, to make it patently clear the link doesn't lead to the MagicJudges blogs. If you'd rather keep the same thumbnail everywhere to be consistent, I can cherry-pick that change out of the PR.

Screenshots

2022-09-15_16-24 2022-09-15_16-25

multimeric commented 2 years ago

How strange that the judges site no longer updates. Well in this case I think it makes sense to change to yawgatog. Can you show me a screenshot of how it looks with your PR? The code itself looks fine.

lunakv commented 2 years ago

Yeah, the site in general became pretty stagnant around the time Judge Academy started operating, and it seems like whoever was in charge of updating the CR just stopped bothering.

I updated the PR descriptions to include some screenshots.

lunakv commented 2 years ago

Merging this means #148 can also be closed btw.