search

braaar / jam-assistant

A web app you can use at a live jam session to come up with ideas. https://braaar.github.io/jam-assistant/
GNU General Public License v3.0
1 stars 6 forks source link

Set up github workflows #3

Open braaar opened 2 years ago

braaar commented 2 years ago

Right now we have the bare minimum in terms of CI/CD. More actions could allow us to do more fancy stuff or facilitate good coding practices

RishiKumarRay commented 2 years ago

I see 2 github actions file i.e we can integrate that in one? like why different files for push and pull , we can just add push and pull both in one?

braaar commented 2 years ago

I see 2 github actions file i.e we can integrate that in one? like why different files for push and pull , we can just add push and pull both in one?

I like having separate files for separate actions, personally. I think it makes it easier to keep track of what is doing what. What is the advantage of putting it all in one file?

RishiKumarRay commented 2 years ago

Oh i see, not a problem that, I don't know of any advantage but yeah just a practice i guess

RishiKumarRay commented 2 years ago

@braaar i was reading about linting, came to know about super linter provided by github check this out, maybe we can implement in linting ? or if you have thought of anything else let me know?

braaar commented 2 years ago

I don't really see why we would need anything more than just a standard yarn lint with eslint. At least for the moment I'm not planning to add any special languages.

RishiKumarRay commented 2 years ago

@braaar i have a raised a PR adding lint , please do check , i read and applied