search

brabster / crucible

AWS CloudFormation templates built with Clojure
Eclipse Public License 1.0
72 stars 18 forks source link

Feature/ecs support #123

Closed keerts closed 6 years ago

keerts commented 6 years ago

Planning to add loadbalancingv2 to this and subnetting, so there is more to come. Treat this pr as a preview. In the meantime, any comment is welcome.

brabster commented 6 years ago

:+1:

brabster commented 6 years ago

Hi @keerts, is this your long-running PR or are you looking to get it merged now?

keerts commented 6 years ago

This is still work in progress, I'm just pushing now and then, to let you know there is progress. It's good stuff, but needs more testing.

brabster commented 6 years ago

Just letting you know - I've made a couple of releases over the last week, nothing major just dependency updates etc. Hopefully won't cause any issues when you merge.

keerts commented 6 years ago

Please don't wait for me. If I run into problems merging I'll figure it out. Next week is going to have more time. We moved into a new office and tomorrow is the opening. If you happen to be in the Netherlands ;-) image

brabster commented 6 years ago

Nice!

keerts commented 6 years ago

Split out the IAM and EC2 parts into separate pull requests. More to follow!

keerts commented 6 years ago

Feel free to deny / close this pr.