search

brabster / crucible

AWS CloudFormation templates built with Clojure
Eclipse Public License 1.0
72 stars 18 forks source link

Add a deps.edn to ease local development #135

Closed keerts closed 6 years ago

keerts commented 6 years ago

Projects that use tools-deps and want to depend on a specific commit sha in the crucible project need a deps.edn present. Ideally project.clj and deps.end dependencies should sync automatically. The is some activity in that area, for example https://github.com/RickMoynihan/lein-tools-deps could fix this. For now we will have to keep it in sync. Switching to tools-deps is also an option...

keerts commented 6 years ago

It could potentially cause problems yes. But, eventually no Clojure project, especially projects that live on contributions by the community, can do without a deps.edn. It makes it a lot more easier to work on local dependent projects or (temporarily) depend on a remote branch in a fork. We are already phasing out leiningen for smaller and library projects!

brabster commented 6 years ago

Sounds good to me. Fine to merge.