search

brack3t / Djrill

[INACTIVE/UNMAINTAINED] Djrill is an email backend and new message class for Django users that want to take advantage of the Mandrill transactional email service from MailChimp.
BSD 3-Clause "New" or "Revised" License
319 stars 64 forks source link

add subaccount support to djrill #62

Closed salsakran closed 10 years ago

salsakran commented 10 years ago

Thanks for creating this! We've been using it heavily, and we're starting to use subaccounts. I've added the ability to specify a subaccount in settings.py.

Not sure if this follows specific ways you want to deal with settings in the future, but wanted to kick this back upstream.

medmunds commented 10 years ago

Thanks for the addition -- and especially for including test cases with it.

Two requests before merging:

  1. The tests seem to be failing.
  2. In your test_send_basic negative test case, it would be good to verify that subaccount hasn't been set in the message.
michaelshobbs commented 10 years ago

Tests failing are my fault. Should have looked more closely at what we were submitting. We'll get it sorted today.

salsakran commented 10 years ago

Fixed, and added the negative test case check!