2.x: drop support for DjrillAdminSite

[medmunds]

Proposal for v2.x: remove the custom DjrillAdminSite.

I'd be curious to hear how often people are actually using the Djrill admin views from within their Django projects' admin sites. (And which admin features you're using.) Please add comments to this issue if you have strong feelings one way or the other.

Rationale for removing this functionality:

• At this point, DjrillAdminSite mainly duplicates reporting functionality that's available (in more useful form) in Mandrill's own control panel.
• The admin views add significantly to the Django version compatibility burden. (E.g., Djrill needs to register its own cycle templatetag for compatibility, purely because of the admin templates.)
• I suspect most Djrill users never look at the Djrill admin views. (Thus the request for feedback above.)

(Incidentally, the admin views originally helped site owners add and validate Mandrill senders -- a process that was relatively cumbersome at the time. But Mandrill dropped that requirement years ago, and we removed it from Djrill as well.)

[rossp]

For me this is not a problem; I have been using djrill for a while and to be perfectly honest I didn't even realise DjrillAdminSite or any other views were available. I just set EMAIL_BACKEND then smile.

[zkanda]

Yeah same here, didn't realize this is available until this issue. Lol!

[walgitrus]

i ran into an issue today working with a new codebase where using admin.site = DjrillAdminSite() was preventing the rest of the admin interface from working.

[chrisvoncsefalvay]

@walgitrus +1 on that. The solution seems to be that if you use 1.7, you need to amend your settings.py file:

...
INSTALLED_APPS = (
    # For Django 1.7+, use SimpleAdminConfig because we'll call autodiscover...
    'django.contrib.admin.apps.SimpleAdminConfig',  # instead of 'django.contrib.admin'
    ...
    'djrill',
    ...
)
...

This is more a result of Django's autodiscovery system being a bit odd rather than Djrill!

[medmunds]

@walgitrus that was issue #74, and @chrisvoncsefalvay has the right answer. (We updated the docs about a month ago to reflect that.)

But needing to make that change was what actually prompted this particular discussion, about removing the Djrill's admin functionality. If (almost) nobody's using it, but lots of people are running into problems it can cause, well...

[kevgathuku]

I am strongly for removing it. I believe it's causing more trouble than benefit. I am experiencing a somewhat similar issue to what @walgitrus is experiencing. The issue is that the Djrill admin simply does not work with the Grapelli admin interface. Changing the settings as suggested in #74 breaks the Grapelli admin and takes me back to Django's default theme.

[medmunds]

@kevgathuku if you're willing to run dev code, DjrillAdminSite is already gone from the v2.0-dev branch. You could install from there. (Dev is, of course, not released. But the tests are passing. I'm going to try to push 2.0 forward to beta my next free weekend.)