search

brack3t / django-braces

Reusable, generic mixins for Django
http://django-braces.readthedocs.org/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
1.96k stars 218 forks source link

Ditch PostgreSQL for testing #258

Closed adamchainz closed 4 years ago

adamchainz commented 4 years ago

Try this. I can't see any PostgreSQL specific features in the repo so I think testing without it is fine.

adamchainz commented 4 years ago

🤷‍♂ why this doesn't work

adamchainz commented 4 years ago

I feel like there was a regression, probably in pytest-django. I recommend pinning all requirements for testing. I have a recipe with pip-compile, see https://github.com/adamchainz/django-cors-headers/tree/master/requirements

kennethlove commented 4 years ago

Hey Adam! Thanks for this PR. I think Baptiste's fix is just a little cleaner so I'm gonna go with that one, but I really appreciate your time and energy on this.

kennethlove commented 4 years ago

(and, yes, I'm going to try and go back and drop Postgres)