search

brack3t / django-braces

Reusable, generic mixins for Django
http://django-braces.readthedocs.org/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
1.96k stars 218 forks source link

Fix/modernizing-braces #277

Closed kennethlove closed 2 years ago

kennethlove commented 3 years ago

like any modern woman, I just want to have it all

Closes #276

This PR is a surface refactor of all of the django-braces code. This should remove all of the Python 2 considerations and generally just make the code nicer.

I'll follow up with tickets for other updates/changes.

codecov-commenter commented 3 years ago

Codecov Report

Merging #277 (1a6afef) into main (e747e99) will increase coverage by 0.41%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   97.28%   97.69%   +0.41%     
==========================================
  Files           8        8              
  Lines         478      477       -1     
  Branches       69       67       -2     
==========================================
+ Hits          465      466       +1     
+ Misses         11        9       -2     
  Partials        2        2
Flag Coverage Δ
unittests 97.69% <100.00%> (+0.41%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
braces/__init__.py 100.00% <ø> (ø)
braces/forms.py 100.00% <100.00%> (ø)
braces/views/_access.py 97.05% <100.00%> (-0.04%) :arrow_down:
braces/views/_ajax.py 100.00% <100.00%> (ø)
braces/views/_forms.py 95.52% <100.00%> (+0.20%) :arrow_up:
braces/views/_other.py 100.00% <100.00%> (+2.06%) :arrow_up:
braces/views/_queries.py 95.38% <100.00%> (ø)
kennethlove commented 3 years ago

The "failed build" is because codecov was unavailable....