search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] add "Brackets" to user agent string, and move remote debugging port to config.h #110

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by joelrbrandt Monday Dec 24, 2012 at 19:36 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/168

Fix for adobe/brackets#2213

Modifies the user agent string to include "Brackets". The user agent string now looks like:

User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/537.1 (KHTML, like Gecko) Brackets Safari/537.1

Ultimately, we probably want to add the build number to the user agent string as well (so it looks something like ... Brackets/0.18.0 ...). However, this will require some changes to the build process because we'll need to figure out a way to have the build number available at compile time. This is discussed in more detail in issue adobe/brackets#2442.

Also moves the hard-coded remote debugging port to a #define in config.h. By having it in config.h, we can set separate ports for Brackets and Edge Code. This means that we can debug both of them at the same time without having to worry about which one we opened first.

joelrbrandt included the following code: https://github.com/adobe/brackets-shell/pull/168/commits

core-ai-bot commented 3 years ago

Comment by joelrbrandt Wednesday Jan 02, 2013 at 18:13 GMT

Based on a comment from @gruehle it looks like we can put the sprint number in the user agent rather easily: https://github.com/adobe/brackets/issues/2442#issuecomment-11817284

So, I'm closing this pull request until I have time to update it.