search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] updated project settings to Xcode 4.4 #17

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jdiehl Tuesday Jul 31, 2012 at 16:11 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/46

I have upgraded the project to run (and compile successfully) on Xcode 4.4. Please verify that this has not broken the project for other Xcode versions.

Also, I know absolutely nothing about gyp. Could someone who is already enlightened update the gyp files?

jdiehl included the following code: https://github.com/adobe/brackets-shell/pull/46/commits

core-ai-bot commented 3 years ago

Comment by joelrbrandt Tuesday Jul 31, 2012 at 16:39 GMT

Thanks.

I'm not actually sure if we want to pull this. The right solution is to update the gyp files so that they generate Xcode 4.4-compliant files. I've filed bug #47 about this.

core-ai-bot commented 3 years ago

Comment by joelrbrandt Tuesday Jul 31, 2012 at 16:42 GMT

Also, we should think about whether we even want xcode / vs project files in the repo long-term. My personal opinion would be "no". It is certainly convenient to have them there (so that if someone pulls the repo they can build without running gyp).

But, it will inevitably lead to pull requests where people change project files instead of gyp files. :-)

And, whenever we do change a gyp file, it will mean that we also need to remember to rebuild and re-commit the project files so they stay in sync. It seems like the entire point of using gyp is to avoid having to maintain several project files.

core-ai-bot commented 3 years ago

Comment by redmunds Tuesday Jul 31, 2012 at 18:31 GMT

In the long term, I agree with what Joel. But, Brackets gyp files seem to be out-of-sync with the project files, so I think's it's ok to pull this in for anyone that needs to build on xcode 4.4 in the short term.

FWIW, I verified that I can build this branch using xcode 3.2.6 on OSX 10.6.8.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Jul 31, 2012 at 19:46 GMT

Works for me on xcode 4.4 on OSX 10.7.4.

+1 Randy and Joel. I still like the idea of keeping the xcode/vs project files to avoid gyp if possible. I haven't finished the gyp instructions in brackets-shell yet, but downloading the bootstrap TAR file of the chromium repo at 1.44 GB wasn't a pleasant start.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Wednesday Aug 01, 2012 at 00:41 GMT

I put up a new pull request #49 to update the gyp file and xcodeproj. Turned out that the changes to gyp weren't as ugly as I thought they might be. @jdiehl, @redmunds and @joelrbrandt maybe you guys can help me sanity check?

Downloading Chromium (for the CHROMIUM_SRC_PATH step) wasn't too bad once I found the TAR here http://chromium-browser-source.commondatastorage.googleapis.com/chromium_tarball.html.

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Aug 01, 2012 at 20:35 GMT

In today's dev meeting, we decided that we will continue to maintain the project files until they can be built without the Chrome source code, so I just tested the new Mac project file. I verified that it works in Xcode 3.2.6 on OS X 10.6.8.

core-ai-bot commented 3 years ago

Comment by jdiehl Wednesday Aug 01, 2012 at 21:20 GMT

The only remaining differences between the project file in this pull request and that in jason's are the SDKROOT (which seems fairly important) and some minor issues that can be ignored. I don't think it matters much, which version gets pulled in (assuming the SDKROOT is fixed ^^)

core-ai-bot commented 3 years ago

Comment by jdiehl Thursday Aug 02, 2012 at 08:23 GMT

This pull request is now obsolete. Please merge #49 instead.