search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] Linux universal installer #202

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by macie Monday Aug 26, 2013 at 22:28 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/316

Linux universal installer

  1. Structure of installer/linux/ dir: \ .. | - / <– distro specified files, eg. PKGBUILD, control | - / | - linux/ <– common files, eg. brackets.desktop | | - .INFO.template <– template (hidden) for INFO file | \ - INFO | - staging/ <– staging folder | - build_installer.sh | - _builder.sh \ - _builder.sh
  2. Description of files:
    • _buildinstaller.sh – checks which distribution is currently used and starts _builder.sh
    • _builder.sh – builds distro-specified package inside __ directory
    • INFO – file with version number and other build-specified information. Generated by task/build.js
  3. Testing I check that 64-bit packages (for ubuntu and arch) builds without errors. I've successful instaled package for arch 64-bit and for ubuntu 64-bit (via https://aur.archlinux.org/packages/brackets/ script).
  4. Package naming convention I use "sprint30" as version number, but perhaps better would be full version number – "0.30.0-0"?

macie included the following code: https://github.com/adobe/brackets-shell/pull/316/commits

core-ai-bot commented 3 years ago

Comment by jasonsanjose Monday Aug 26, 2013 at 22:45 GMT

Wow, thanks @macie for the contribution. The end of sprint 30 is coming up on Wednesday, so I probably won't have time to fully review and test this pull request by then. I'll make sure this is on our list for sprint 31.

core-ai-bot commented 3 years ago

Comment by thefirstofthe300 Monday Aug 26, 2013 at 22:52 GMT

Agree with Jason. OMG, that is a lot of help.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Aug 27, 2013 at 17:24 GMT

Tagged Sprint 31.

core-ai-bot commented 3 years ago

Comment by ingorichter Tuesday Aug 27, 2013 at 17:49 GMT

That is a great contribution. Thank you. BTW: did anybody try to install on a 32Bit System?

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Sep 03, 2013 at 20:12 GMT

@macie I want to get a good grip on creating packages for arch linux. Is this https://wiki.archlinux.org/index.php/Creating_Packages a good resource or have you found others?

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Sep 03, 2013 at 21:19 GMT

Can we rename installer/linux/linux to installer/linux/common?

core-ai-bot commented 3 years ago

Comment by jasonsanjose Tuesday Sep 03, 2013 at 21:33 GMT

@macie Initial review complete, but I haven't really reviewed the Arch packaging yet. I'm having some difficulties getting that setup. If you know someone else who is more familiar with Arch that can at least test your package and possibly review the PKGBUILD file, that would help.

core-ai-bot commented 3 years ago

Comment by macie Monday Sep 09, 2013 at 20:03 GMT

@jasonsanjose building packages for arch linux is quite simple. It use makepkg command on PKGBUILD file.

Yes, installer/linux/common sounds better than installer/linux/linux.

PS. Apologize for my absence

core-ai-bot commented 3 years ago

Comment by jasonsanjose Wednesday Sep 11, 2013 at 20:35 GMT

@macie thanks for the follow up. Please drop a comment for me here when you've pushed your changes. Please note that I'll be out on vacation starting the end of next week. If this pull request is still open @JeffryBooher will assist.

Also note that our sprint ends next Wednesday, September 19. Ideally we would like to land these changes sooner to get more testing.

core-ai-bot commented 3 years ago

Comment by macie Thursday Sep 12, 2013 at 20:53 GMT

@jasonsanjose Tomorrow I'll try to finish this pull request.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Monday Sep 16, 2013 at 18:13 GMT

Moved out of sprint 31