Open core-ai-bot opened 3 years ago
Comment by jasonsanjose Monday Aug 26, 2013 at 22:45 GMT
Wow, thanks @macie for the contribution. The end of sprint 30 is coming up on Wednesday, so I probably won't have time to fully review and test this pull request by then. I'll make sure this is on our list for sprint 31.
Comment by thefirstofthe300 Monday Aug 26, 2013 at 22:52 GMT
Agree with Jason. OMG, that is a lot of help.
Comment by ingorichter Tuesday Aug 27, 2013 at 17:49 GMT
That is a great contribution. Thank you. BTW: did anybody try to install on a 32Bit System?
Comment by jasonsanjose Tuesday Sep 03, 2013 at 20:12 GMT
@macie I want to get a good grip on creating packages for arch linux. Is this https://wiki.archlinux.org/index.php/Creating_Packages a good resource or have you found others?
Comment by jasonsanjose Tuesday Sep 03, 2013 at 21:19 GMT
Can we rename installer/linux/linux
to installer/linux/common
?
Comment by jasonsanjose Tuesday Sep 03, 2013 at 21:33 GMT
@macie Initial review complete, but I haven't really reviewed the Arch packaging yet. I'm having some difficulties getting that setup. If you know someone else who is more familiar with Arch that can at least test your package and possibly review the PKGBUILD file, that would help.
Comment by macie Monday Sep 09, 2013 at 20:03 GMT
@jasonsanjose building packages for arch linux is quite simple. It use makepkg command on PKGBUILD file.
Yes, installer/linux/common
sounds better than installer/linux/linux
.
PS. Apologize for my absence
Comment by jasonsanjose Wednesday Sep 11, 2013 at 20:35 GMT
@macie thanks for the follow up. Please drop a comment for me here when you've pushed your changes. Please note that I'll be out on vacation starting the end of next week. If this pull request is still open @JeffryBooher will assist.
Also note that our sprint ends next Wednesday, September 19. Ideally we would like to land these changes sooner to get more testing.
Comment by macie Thursday Sep 12, 2013 at 20:53 GMT
@jasonsanjose Tomorrow I'll try to finish this pull request.
Issue by macie Monday Aug 26, 2013 at 22:28 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/316
Linux universal installer
macie included the following code: https://github.com/adobe/brackets-shell/pull/316/commits