search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] Implement Brackets Update-in-place via Installer #238

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by bchintx Monday Nov 04, 2013 at 19:11 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/370

Removes "Sprint" suffix from the Brackets application name in support of updating future releases in-place (as opposed to installing into separate folders). See Trello user story. Also requires associated Brackets Pull Request #5843.

On Windows, removes "Sprint" suffix from:

On OSX, removes "Sprint" suffix from:

To test, install the updated .msi (Windows) or .dmg (OSX), and confirm that the displayed name in the above areas have been changed. There is no change to Linux installations.

When testing the upgrade scenario (ie. installing a newer version), confirm that future releases replace any previously existing, installed earlier releases (although not the ones that still have the "Sprint" suffix in the app name). In other words, after installing Brackets Sprint 34, installing Sprint 35 should completely replace the installed Sprint 34 release, resulting in only the Sprint 35 release being available to run.

Please note that any already installed Sprint 33 and earlier already shipping releases should not be affected by this change -- ie. those installed releases will remain installed on the system.

bchintx included the following code: https://github.com/adobe/brackets-shell/pull/370/commits

core-ai-bot commented 3 years ago

Comment by couzteau Wednesday Nov 06, 2013 at 23:13 GMT

installer/mac/buildInstaller.sh has a line that substitutes the string APPLICATION_NAME with the value of releaseName in the staged Info.plist. line 38

It seems to be a good opportunity to remove that line and update the submitted Info.plist at https://github.com/adobe/brackets-shell/blob/master/installer/mac/dropDmgConfig/layouts/bracketsLayout/Info.plist

core-ai-bot commented 3 years ago

Comment by couzteau Wednesday Nov 06, 2013 at 23:14 GMT

@ingorichter maybe you want to give this a once over as the installer expert.

core-ai-bot commented 3 years ago

Comment by couzteau Wednesday Nov 06, 2013 at 23:15 GMT

Done with initial review.

core-ai-bot commented 3 years ago

Comment by bchintx Thursday Nov 07, 2013 at 17:59 GMT

@couzteau regarding your comment above to update how buildInstaller.sh substitutes APPLICATION_NAME, are you asking to remove the grep command line from buildInstaller.sh and just hard-code "Brackets.app" into that Info.plist file?

core-ai-bot commented 3 years ago

Comment by couzteau Thursday Nov 07, 2013 at 18:49 GMT

@bchintx Yep. That's what I thought.

core-ai-bot commented 3 years ago

Comment by bchintx Thursday Nov 07, 2013 at 21:21 GMT

@couzteau Done as requested. Hard-coded the "Brackets.app" name into the dropDMG info.plist and removed that command from buildInstaller.sh.

core-ai-bot commented 3 years ago

Comment by couzteau Thursday Nov 07, 2013 at 21:40 GMT

Done with review. This looks good. @ingorichter has blessed the changes verbally

core-ai-bot commented 3 years ago

Comment by bchintx Saturday Nov 09, 2013 at 04:16 GMT

@couzteau This pull request is now ready for you to merge. All scenario testing is complete, and I've updated the branch with the latest changes in master. Thanks!