brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] Fix Brackets Live Development Issues with Chrome OSX #239

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by fungl164 Tuesday Nov 05, 2013 at 22:03 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/371


This provides better real-time detection/separation of Chrome debug sessions, as well as better connectivity + window/tab management from within Brackets.


fungl164 included the following code: https://github.com/adobe/brackets-shell/pull/371/commits

core-ai-bot commented 3 years ago

Comment by redmunds Wednesday Nov 06, 2013 at 00:15 GMT


@fungl164 Thanks for all of your work on this. Merging.

core-ai-bot commented 3 years ago

Comment by njx Wednesday Nov 06, 2013 at 00:51 GMT


SO AWESOME. Thanks @fungl164!

@redmunds, we should probably look around the various docs to find references to the "relaunch" dialog and remove them. The smoke tests are the main one that comes to mind, but there might be references in Getting Started, How to Use Brackets, etc.

core-ai-bot commented 3 years ago

Comment by fungl164 Wednesday Nov 06, 2013 at 17:12 GMT


@njx it feels good to give back to the community. Thank you guys putting out Brackets as well!

re: "relaunch", you might also want to take a look at the _openInterstitialPage() sequence. In earlier trials I had a small patch which removed the need to reconnect the Inspector object using timeouts. For simplicity purposes, I took it out for this part, so it hasn't been tested well enough.

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Nov 07, 2013 at 19:22 GMT


@njx Done. I updated Client & Server Smokes, and How to Use Brackets.

core-ai-bot commented 3 years ago

Comment by njx Thursday Nov 07, 2013 at 21:52 GMT


Thanks. I wonder if we should mention in How to Use Brackets that we open a separate Chrome instance.

Also, in the smoke tests, would it make sense to actually have the tester double-check that Chrome was opened in a separate profile?