search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] Fixes several aero and dark shell issues #288

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by JeffryBooher Thursday May 15, 2014 at 16:37 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/443

Fixes:

Two issues reported by @MartinMa

Adds:

JeffryBooher included the following code: https://github.com/adobe/brackets-shell/pull/443/commits

core-ai-bot commented 3 years ago

Comment by MartinMa Thursday May 15, 2014 at 17:48 GMT

Looks great! :thumbsup: That was very fast :smiley:

core-ai-bot commented 3 years ago

Comment by bchintx Thursday May 15, 2014 at 22:30 GMT

@JeffryBooher Done with initial review. Overall, changes look fine. Couple of nit-picky comments, and one bigger concern w/ the RGB choices.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Friday May 16, 2014 at 01:10 GMT

@bchintx I changed the color per @larz0 suggestion. Let me know what you think.

core-ai-bot commented 3 years ago

Comment by bchintx Friday May 16, 2014 at 05:39 GMT

@JeffryBooher Thanks for the misc corrections, and, yes, @larz0 's updated inactive frame color looks better. Still, I have two questions/concerns:

(1) is the 1 pel "white" border around the inactive window an intentional change? IMHO, it's a non-standard Window style, and when it's lit up like that, I keep thinking that that window has focus and is in the middle of a window drag operation or something.

(2) I don't notice this in master, but with your branch, if I click-drag the right window border to resize the window, then I'm seeing a flickering white line across the bottom of the main menu area. It only happens while I'm dragging. As soon as I pause or release the mouse button, the white bar is repainted to the background color correctly. However, so long as I'm drag-resizing, the flickering continues.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Friday May 16, 2014 at 06:18 GMT

&larz0 what do you want to do about true white tuxedo border?

core-ai-bot commented 3 years ago

Comment by JeffryBooher Friday May 16, 2014 at 06:19 GMT

@bchintx I didn't notice the dragging issue but will take a look.

core-ai-bot commented 3 years ago

Comment by larz0 Friday May 16, 2014 at 06:25 GMT

@JeffryBooher let's use #3c3f41 for the 1px border.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Friday May 16, 2014 at 16:40 GMT

@bchintx I'm unable to reproduce the flickering line on Windows 8.1 and my fast machine. I can walk you through debugging it if you have time and want to fix it.

core-ai-bot commented 3 years ago

Comment by bchintx Monday May 19, 2014 at 22:57 GMT

Confirmed that latest changes fix: