search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] [MAC] Fix for not being able to minimize Brackets full screen window on El Capitan. #353

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by nethip Monday Jun 29, 2015 at 04:58 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/526

Fixes the issue with maverick OS style minimize/maximize/close buttons appearing on El Capitan and also fixes 'unable to minimize from a full screen window on MAC OS El Capitan'.

Add a better way of checking for Yosemite. Documentation available at the following location.

https://developer.apple.com/library/mac/documentation/DeveloperTools/Conceptual/cross_development/Using/using.html

nethip included the following code: https://github.com/adobe/brackets-shell/pull/526/commits

core-ai-bot commented 3 years ago

Comment by nethip Monday Jun 29, 2015 at 05:04 GMT

https://github.com/adobe/brackets/issues/9608

@ingorichter It would be great if you can review this small change.

cc @JeffryBooher

core-ai-bot commented 3 years ago

Comment by nethip Monday Jul 06, 2015 at 05:03 GMT

@alexbock Thanks for taking some time in reviewing this. I think even if the floor is in place the chance of the failure is minimal as the >= will take care of the condition properly given the fact that all the major version numbers of OS from MAC are integral. Here is a list of version nos taken from NSAppliction.h

#define NSAppKitVersionNumber10_0 577
#define NSAppKitVersionNumber10_1 620
#define NSAppKitVersionNumber10_2 663
#define NSAppKitVersionNumber10_2_3 663.6
#define NSAppKitVersionNumber10_3 743
#define NSAppKitVersionNumber10_3_2 743.14
#define NSAppKitVersionNumber10_3_3 743.2
#define NSAppKitVersionNumber10_3_5 743.24
#define NSAppKitVersionNumber10_3_7 743.33
#define NSAppKitVersionNumber10_3_9 743.36
#define NSAppKitVersionNumber10_4 824
#define NSAppKitVersionNumber10_4_1 824.1
#define NSAppKitVersionNumber10_4_3 824.23
#define NSAppKitVersionNumber10_4_4 824.33
#define NSAppKitVersionNumber10_4_7 824.41
#define NSAppKitVersionNumber10_5 949
#define NSAppKitVersionNumber10_5_2 949.27
#define NSAppKitVersionNumber10_5_3 949.33
#define NSAppKitVersionNumber10_6 1038
#define NSAppKitVersionNumber10_7 1138
#define NSAppKitVersionNumber10_7_2 1138.23
#define NSAppKitVersionNumber10_7_3 1138.32
#define NSAppKitVersionNumber10_7_4 1138.47
#define NSAppKitVersionNumber10_8 118

But having said that there is not reason for us to have floor here. I will remove the floor condition and update this PR. Thanks for your insights though.