search

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.
http://brackets.io
MIT License
0 stars 0 forks source link

[CLOSED] Remove a number of unnecessary file associations #362

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by le717 Monday Feb 01, 2016 at 17:49 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/547

Brackets is a front-end web code editor. The Windows installer, however, registers a ton of file associations that were too generic, should belong to another IDE, or were not at all related. Combined with lack of an installation option to choose what should be registered, issues such as adobe/brackets#6073 have been created.

One fix mentioned (and agreed with multiple times) is to drop the aforementioned associations from being registered. This PR does exactly that, dropping, Python, C/C#/C++, Ruby, Java (and like-Java), Perl, and generic extensions (e.g., properties, ini, txt). I left PHP in-place.

With this change, the number of associations registered drops from 92 to 57. That is still a very high number and could still be lowered, but it is already a drastic improvement.

le717 included the following code: https://github.com/adobe/brackets-shell/pull/547/commits

core-ai-bot commented 2 years ago

Comment by ryanstewart Monday Feb 01, 2016 at 17:57 GMT

Thanks @le717. I don't see any reason not to merge this from an ideal user-experience aspect. @nethip who has the most shell experience on the team to determine if this PR will cause any issues?

core-ai-bot commented 2 years ago

Comment by nethip Thursday Apr 07, 2016 at 05:24 GMT

Sorry for being really late on this thread. @ryanstewart Shouldn't be an issue. We could go with the merge.

@le717 Thanks for this PR.