[CLOSED] Accept only local origin connection request

brackets-archive / brackets-shell

CEF3-based application shell for Brackets.

http://brackets.io

MIT License

0 stars 0 forks source link

Open core-ai-bot opened 2 years ago

core-ai-bot commented 2 years ago

Issue by swmitra Thursday Apr 28, 2016 at 12:42 GMT Originally opened as https://github.com/adobe/brackets-shell/pull/550

This PR is to add some additional client verification before accepting a new Node web socket connection.

Ping @petetnt @MarcelGerber @abose for review.

swmitra included the following code: https://github.com/adobe/brackets-shell/pull/550/commits

core-ai-bot commented 2 years ago

Comment by ingorichter Wednesday May 04, 2016 at 17:21 GMT

Is there any official issue filed that this PR will fix? Just curious.

core-ai-bot commented 2 years ago

Comment by swmitra Thursday May 05, 2016 at 05:30 GMT

@ingorichter sent you the relevant details over email.

core-ai-bot commented 2 years ago

Comment by ingorichter Thursday May 12, 2016 at 01:25 GMT

After reading the email, the change looks good to me. As usual, it would be great to have some unit tests to ensure the desired behavior.

core-ai-bot commented 2 years ago

Comment by swmitra Thursday May 12, 2016 at 04:34 GMT

Thanks a lot @ingorichter. I will try to add some unit tests for verifyClient call.

core-ai-bot commented 2 years ago

Comment by nethip Friday May 13, 2016 at 11:15 GMT

@swmitra I have added a waffle task for this. If you think this is going to take more time, we could target this for the next release.

core-ai-bot commented 2 years ago

Comment by nethip Friday May 13, 2016 at 11:54 GMT

@swmitra Thanks for the PR!